RFR(trivial): 8233659: [TESTBUG] runtime/cds/appcds/CommandLineFlagCombo.java fails when jfr is disabled

Jie Fu fujie at loongson.cn
Wed Nov 6 05:49:10 UTC 2019


Hi Ioi,

Thanks for your review and valuable comments.

Very good ideal.
Updated: http://cr.openjdk.java.net/~jiefu/8233659/webrev.01/

Hope you can sponsor it if you are OK with the change.

Thanks a lot.
Best regards,
Jie

On 2019/11/6 上午11:59, Ioi Lam wrote:
> Hi Jie,
>
> I think the better fix is to call WhiteBox.isJFRIncludedInVmBuild() 
> inside CommandLineFlagCombo.skipTestCase(). That way you can test 
> other flags even when JFR is not included.
>
> Thanks
> - Ioi
>
> On 11/5/19 7:07 PM, Jie Fu wrote:
>> Hi all,
>>
>> May I get reviews for the one-line change?
>>
>> JBS:    https://bugs.openjdk.java.net/browse/JDK-8233659
>> Webrev: http://cr.openjdk.java.net/~jiefu/8233659/webrev.00/
>>
>> Thanks a lot.
>> Best regards,
>> Jie
>>
>>
>



More information about the hotspot-runtime-dev mailing list