RFR(T): 8233530: gcc 5.4 build warning -Wc++14-compat after JDK-8233359

[Thomas Stüfe]

Okay I'm fine with that.

Thanks, Thomas

On Wed, Nov 6, 2019, 18:50 Kim Barrett <kim.barrett at oracle.com> wrote:

> > On Nov 6, 2019, at 9:46 AM, Kim Barrett <kim.barrett at oracle.com> wrote:
> >
> >> On Nov 6, 2019, at 8:21 AM, David Holmes <david.holmes at oracle.com>
> wrote:
> >>
> >> On 6/11/2019 11:17 pm, Thomas Stüfe wrote:
> >>> Hi David,
> >>> sorry for that. I had marked this as trivial, understood your initial
> answer as valid Review and pushed this after getting a second review from
> Goetz.
> >>> But no problem, I can do a follow up patch. What are the remaining
> criticisms? Removal of the _GNUG_ define?
> >>
> >> I'll let Kim decide whether it is worth following up on this.
> >
> > Those #ifdefs look really odd, and this file might not be touched again
> for a while.
> > What’s one more time through the spin cycle? :)  Sigh.  I thought
> 8233359 was going to be easy.
>
> Let’s leave it to post JEP 347 cleanup:
> https://bugs.openjdk.java.net/browse/JDK-8233724
>
>