RFR(T): 8232244: [TESTBUG] Incorrect comment in TestClassUnloadEvent.java

Mikhailo Seledtsov mikhailo.seledtsov at oracle.com
Thu Nov 14 19:17:31 UTC 2019


Thanks Igor, pushed.

On 11/14/19, 10:54 AM, Igor Ignatev wrote:
> LGTM
>
> — Igor
>
>> On Nov 14, 2019, at 10:36 AM, Mikhailo Seledtsov<mikhailo.seledtsov at oracle.com>  wrote:
>>
>> Please review this change that removes incorrect comment. Both statements in the comment are incorrect, hence removing the comment.
>>
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8232244
>>
>> Change:
>>   --- a/test/jdk/jdk/jfr/event/runtime/TestClassUnloadEvent.java
>>   +++ b/test/jdk/jdk/jfr/event/runtime/TestClassUnloadEvent.java
>>   @@ -47,12 +47,6 @@
>>   * @run main/othervm -Xlog:class+unload -Xlog:gc -Xmx16m jdk.jfr.event.runtime.TestClassUnloadEvent
>>   */
>>
>>   -/**
>>   - * System.gc() will trigger class unloading if -XX:+ExplicitGCInvokesConcurrent is NOT set.
>>   - * If this flag is set G1 will never unload classes on System.gc().
>>   - * As far as the "jfr" key guarantees no VM flags are set from the outside
>>   - * it should be enough with System.gc().
>>   - */
>>
>>
>> Testing:
>>    1. Ran the updated test: PASS
>>
>>
>> Thank you,
>> Misha
>>


More information about the hotspot-runtime-dev mailing list