RFR(S/T): 8230876: baseline cleanups from Async Monitor Deflation v2.0[789]

[David Holmes]

Hi Dan,

Given:

  volatile intptr_t _recursions;

The change to the print statements to use INTX_FORMAT instead of the 
existing INTPTR_FORMAT seems a little odd - but obviously you don't want 
it printed in hex. That seems fine, but can we then make the simple 
change to redefine _recursions as intx as well - which is a semantic 
no-op given:

typedef intptr_t  intx;

Otherwise all seems okay.

Thanks,
David

On 19/11/2019 8:23 am, Daniel D. Daugherty wrote:
> Greetings,
> 
> I have another round of baseline cleanup changes from the Async Monitor
> Deflation project (8153224). Like previous sub-tasks of 8153224, these
> changes are small and/or trivial. These changes have previously been
> reviewed as a (very) small part of 8153224 (CR8/v2.08/11-for-jdk14).
> 
> Vladimir K., if you could sanity check the cleanups in 
> macroAssembler_x86.cpp
> that would be appreciated (only comments were changed). I recommend the
> Udiff view...
> 
> Please see the bug for details about the changes in this webrev:
> 
>      JDK-8230876 baseline cleanups from Async Monitor Deflation v2.0[789]
>      https://bugs.openjdk.java.net/browse/JDK-8230876
> 
> Here's the webrev URL:
> 
>      http://cr.openjdk.java.net/~dcubed/8230876-webrev/0-for-jdk14/
> 
> These changes have been included in my recent rounds of Mach5 Tier[1-8]
> and other associated stress and/or performance testing. I have also done
> a Mach5 Tier[1-3] run with just this patch to make sure that I got all
> the pieces that are needed.
> 
> Thanks, in advance, for any comments, questions or suggestions.
> 
> Dan