RFR(S): 8233113: ARM32: assert on UnsafeJlong mutex rank check

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Tue Nov 19 03:42:51 UTC 2019


This looks good!  Thank you for fixing it.
Coleen

On 11/18/19 9:35 AM, Boris Ulasevich wrote:
> David, thank you!
>
> Dear all,
>
>   Can anybody else take a look at the review please?
>   Or should I consider the change trivial?
>
> thanks,
> Boris
>
> On 11.11.2019 13:56, David Holmes wrote:
>> Hi Boris,
>>
>> This seems fine to me.
>>
>> Thanks,
>> David
>>
>> On 8/11/2019 11:28 pm, Boris Ulasevich wrote:
>>> Hi,
>>>
>>> Recent JDK-8184732 change adds the assertion that fires on 
>>> UnsafeJlong mutex rank check, on platforms without 64 bit atomics 
>>> compare-and-exchange support. On preliminary review (thanks to 
>>> Coleen and David!) it is suggested to remove the assertion and 
>>> corresponding test codes.
>>>
>>> http://bugs.openjdk.java.net/browse/JDK-8233113
>>> http://cr.openjdk.java.net/~bulasevich/8233113/webrev.01
>>>
>>> Thanks,
>>> Boris



More information about the hotspot-runtime-dev mailing list