RFR (S): 8230611: infinite loop in LogOutputList::wait_until_no_readers()
coleen.phillimore at oracle.com
coleen.phillimore at oracle.com
Thu Nov 21 23:04:36 UTC 2019
Buck, thanks for fixing this and Kim for your comments, and David for
reviewing. It looks good to me also.
Coleen
On 11/21/19 5:37 PM, David Holmes wrote:
> On 22/11/2019 6:37 am, Kim Barrett wrote:
>>> On Nov 21, 2019, at 3:24 PM, David Buck <david.buck at oracle.com> wrote:
>>>
>>> Hi Kim!
>>>
>>> Thanks again for helping me to get this fix in shape.
>>>
>>> Once again, I agree with everything you said. I have returned the
>>> copy ctor to my first version (using an initializer list), and have
>>> modified the copy assignment so that it now exactly matches your
>>> number 2 suggestion from your previous response.
>>>
>>> Here is a new (and hopefully final) webrev:
>>>
>>> http://cr.openjdk.java.net/~dbuck/8230611_ver02/
>>>
>>> I am still running the sanity check builds / tests in the
>>> background. But seeing how the copy ctor is simply a reversion back
>>> to the already thoroughly-tested version from earlier, and that the
>>> copy assignment override is dead code in our builds, I do not expect
>>> any surprises.
>>>
>>> Does the latest webrev look good? Any other thoughts or feedback?
>>
>> Looks good.
>
> +1
>
> Thanks Kim for resolving all the technical nuances.
>
> Thanks Buck for fixing this issue.
>
> Cheers,
> David
>
>
>
More information about the hotspot-runtime-dev
mailing list