RFR 8234613: JavaThread can escape back to Java from an ongoing handshake

Robbin Ehn robbin.ehn at oracle.com
Tue Nov 26 11:01:49 UTC 2019


Thanks Patricio!

/Robbin

On 11/25/19 7:58 PM, Patricio Chilano wrote:
> Hi Robbin,
> 
> On 11/25/19 4:14 AM, Robbin Ehn wrote:
>> Hi Patricio,
>>
>> On 2019-11-22 19:25, Patricio Chilano wrote:
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8234613
>>> Webrev: http://cr.openjdk.java.net/~pchilanomate/8234613/v01/webrev/
>>
>> Thanks, I think this is good and easy to backport!
>> You might as well add native to the assert.
> Added!
> 
>> We should revisit this when we have time.
>> There are two polls and four transition in this code, which is more complicated
>> than I like.
> Agree, I think it could be simplified.
> 
> Here is v2:
> http://cr.openjdk.java.net/~pchilanomate/8234613/v02/webrev/ 
> <http://cr.openjdk.java.net/~pchilanomate/8234613/v02/webrev/src/hotspot/share/runtime/handshake.cpp.udiff.html>
> 
> Thanks for looking at this Robbin!
> 
> Patricio
>> /Robbin
>>
>>>
>>> Thanks,
>>> Patricio
> 


More information about the hotspot-runtime-dev mailing list