RFR 8234656: Improve granularity of verifier logging

[David Holmes]

Hi Harold,

On 27/11/2019 2:19 am, Harold Seigel wrote:
> Hi David,
> 
> Thanks for looking at this change.  Please review this updated webrev 
> that moves the new test functionality into the existing hotspot 
> .../logging/VerificationTest.java test.
> 
>     http://cr.openjdk.java.net/~hseigel/bug_8234656.2/webrev/index.html

Thanks for doing that. You could integrate it a little more by having 
analyzeOutputOn take a parameter to indicate whether info or debug 
logging should be expected. But no big deal.

   66         pb = ProcessTools.createJavaProcessBuilder("-Xverify:all",
   67 
"-Xlog:verification=debug",
   68                                                    "-Xshare:off",
   69                                                    "-version");

why those flags versus just

pb = ProcessTools.createJavaProcessBuilder("-Xlog:verification=debug",
                                          InternalClass.class.getName());

?

Thanks,
David
> 
> Thanks, Harold
> 
> On 11/25/2019 5:30 PM, David Holmes wrote:
>> Hi Harold,
>>
>> On 26/11/2019 3:13 am, Harold Seigel wrote:
>>> Hi,
>>>
>>> Please review this small change to improve the granularity of 
>>> verifier logging.  This change provides brief output for log level 
>>> info and detailed logging for log levels debug and trace. 
>>> Additionally, it changes verifier test TraceClassRes.java to use the 
>>> logging API command line options.
>>
>> Deciding what to log at what level is highly subjective :) This change 
>> seems okay though as anyone who wants the current output can enable 
>> "debug" logging for verification and won't then get a tonne of other 
>> stuff they didn't want.
>>
>> The new test functionality could be added to the existing:
>>
>> ./hotspot/jtreg/runtime/logging/VerificationTest.java
>>
>> Thanks,
>> David
>> -----
>>
>>> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8234656/webrev/
>>>
>>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8234656
>>>
>>> The fix was regression tested by running Mach5 tiers 1 and 2 tests 
>>> and builds on Linux-x64, Solaris, Windows, and Mac OS X, by running 
>>> Mach5 tiers 3-5 tests on Linux-x64, and JCK lang and VM tests on 
>>> Linux-x64.
>>>
>>> Thanks, Harold
>>>