RFR(xs) 8231606: _method_ordering is not set during CDS dynamic dump time

[Calvin Cheung]

On 10/1/19 2:12 PM, coleen.phillimore at oracle.com wrote:
>
>
> On 10/1/19 4:32 PM, Calvin Cheung wrote:
>>
>> On 10/1/19 12:53 PM, Jiangli Zhou wrote:
>>> On Tue, Oct 1, 2019 at 12:15 PM <coleen.phillimore at oracle.com> wrote:
>>>>
>>>> It might be a good idea to go through and add some
>>>>
>>>> public static bool is_dumping_archive() { return DumpSharedSpaces ||
>>>> DynamicDumpSharedSpaces); }
>>>>
>>>> And replace all of these sets of conditionals with it, since it 
>>>> appears
>>>> that this case was missed.
>>> I was going to suggest something similar with a macro. A function
>>> probably is better.
>>
>> I will add the function in arguments.hpp since it will be called in 
>> several places spanning several files.
>
> Yes, arguments.hpp seems fine.  There are a lot of these.

Updated webrev:

http://cr.openjdk.java.net/~ccheung/8231606/webrev.01/

I've run CDS/AppCDS tests locally on linux-x64.

Re-running tier1 - 3 tests.

thanks,

Calvin

> thanks,
> Coleen
>>
>> Is it ok?
>>
>> thanks,
>>
>> Calvin
>>
>>>
>>> Best,
>>> Jiangli
>>>> Coleen
>>>>
>>>> On 10/1/19 1:14 PM, Calvin Cheung wrote:
>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8231606
>>>>>
>>>>> webrev: http://cr.openjdk.java.net/~ccheung/8231606/webrev.00/
>>>>>
>>>>> A small fix for setting up the _method_ordering field during CDS
>>>>> dynamic dumping.
>>>>>
>>>>> Testing: tier1 - 3.
>>>>>
>>>>> thanks,
>>>>>
>>>>> Calvin
>>>>>
>