RFR (XS/T) 8231930: Windows build fails after JDK-8191521

Aleksey Shipilev shade at redhat.com
Mon Oct 7 13:01:02 UTC 2019


Thanks, pushed!

-Aleksey

On 10/7/19 1:48 PM, David Holmes wrote:
> Hi Aleksey,
> 
> Looks good and trivial.
> 
> Thanks,
> David
> -----
> 
> On 7/10/2019 8:47 pm, Aleksey Shipilev wrote:
>> Bug:
>>    https://bugs.openjdk.java.net/browse/JDK-8231930
>>
>> Fix:
>>
>> diff -r 97cd0aa39787 test/hotspot/gtest/runtime/test_os_windows.cpp
>> --- a/test/hotspot/gtest/runtime/test_os_windows.cpp    Mon Oct 07 07:53:38 2019 +0200
>> +++ b/test/hotspot/gtest/runtime/test_os_windows.cpp    Mon Oct 07 12:45:10 2019 +0200
>> @@ -355,5 +355,5 @@
>>     if (convert_to_cstring(buf, JVM_MAXPATHLEN, path)) {
>>       ::testing::Test::RecordProperty(name, buf);
>> -    snprintf(buf, JVM_MAXPATHLEN, "%d", (int) wcslen(path));
>> +    os::snprintf(buf, JVM_MAXPATHLEN, "%d", (int) wcslen(path));
>>       ::testing::Test::RecordProperty(len_name, buf);
>>     }
>>
>> This follows the relevant Windows build fixes: we use os::snprintf [1].
>>
>> Testing: windows build, gtest:os (runs affected test)



More information about the hotspot-runtime-dev mailing list