RFR: 8232082: Log which shows disabling COOP should be tagged to gc+heap+coops

David Holmes david.holmes at oracle.com
Thu Oct 10 04:58:31 UTC 2019


Hi Yasumasa,

On 10/10/2019 12:34 pm, Yasumasa Suenaga wrote:
> Hi all,
> 
> Please review this change:
> 
>    JBS: https://bugs.openjdk.java.net/browse/JDK-8232082
>    webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8232082/webrev.00/
> 
> 
> Log message is tagged to "cds" when COOP is disabled by ergonomics due 
> to heap size. This log has introduced in JDK-8226462.
> But it might occur outside of CDS. So it should be tagged to 
> "gc+heap+coops" instead of "cds".

The logging wasn't put in to show the conditions under which the 
ergonomics kicked in, it was put in to show CDS users that it had kicked in.

So if you think it should be logged under additional conditions, that is 
fine, but please do not replace the existing logging.

Unfortunately there is no nice way to log the same information under 
multiple tags.

Thanks,
David

> 
> 
> Thanks,
> 
> Yasumasa


More information about the hotspot-runtime-dev mailing list