RFR(S): 8165056: move JIT Compiler related files from runtime/ to compiler/ directory

[Liu Xin]

hi, Coleen,

I did the clean-up. now it looks neater!
https://cr.openjdk.java.net/~xliu/8165056/v4/webrev/

if it looks good, could you sponsor me to push?
thanks,
--lx


On Wed, Oct 9, 2019 at 2:41 PM <coleen.phillimore at oracle.com> wrote:

>
> One further cleanup:  The #include directives should be sorted
> alphabetically, so compiler/compilationPolicy.cpp should be moved out of
> the runtime section.
>
> Thank you for the extra #include cleanups.
>
> Coleen
>
> On 10/9/19 4:06 PM, Liu Xin wrote:
> > hi, Vladimir,
> >
> > Yes. I  modified it.
> > https://cr.openjdk.java.net/~xliu/8165056/v3/webrev/
> >
> > I verified to build it without jvmci.
> >
> > thanks,
> > --lx
> >
> > On Wed, Oct 9, 2019 at 12:18 PM Vladimir Kozlov <
> vladimir.kozlov at oracle.com>
> > wrote:
> >
> >> #include jvmciCompiler.hpp should be under #if INCLUDE_JVMCI and at the
> >> end of includes block:
> >>
> >>
> >>
> http://hg.openjdk.java.net/jdk/jdk/file/fb3d408c7a7e/src/hotspot/share/runtime/thread.cpp#l120
> >>
> >> Otherwise it is good.
> >>
> >> Thanks,
> >> Vladimir
> >>
> >> On 10/9/19 11:59 AM, Liu Xin wrote:
> >>> Hi, Coleen and Vladimir,
> >>>
> >>> Indeed, some files don't depend on the header compilationPolicy.hpp, so
> >>> I remove them. In particular, jni.cpp actually depends on
> >>> jvmciCompiler.hpp instead of compilationPolicy.hpp.
> >>>
> >>> I did extra hg massage to make it clear.
> >>> https://cr.openjdk.java.net/~xliu/8165056/v2/webrev/
> >>>
> >>> I built it successfully and it's still running tests.
> >>>
> >>> thanks,
> >>> --lx
> >>>
> >>>
> >>> On Wed, Oct 9, 2019 at 11:31 AM Vladimir Kozlov
> >>> <vladimir.kozlov at oracle.com <mailto:vladimir.kozlov at oracle.com>>
> wrote:
> >>>
> >>>      On 10/9/19 5:57 AM, coleen.phillimore at oracle.com
> >>>      <mailto:coleen.phillimore at oracle.com> wrote:
> >>>       >
> >>>       > Thank you for doing this!
> >>>       >
> >>>       > Can you check that compilationPolicy.hpp is actually needed to
> be
> >>>       > included from the non-compiler files?
> >>>
> >>>      Yes, it would be nice to clean up not-needed #include.
> >>>
> >>>       >
> >>>       > Did you use hg mv for compilationPolicy* ?
> >>>
> >>>      Webrev show previous files location which I assume indication of
> `hg
> >> mv`
> >>>      Thanks,
> >>>      Vladimir
> >>>
> >>>       >
> >>>       > Thanks,
> >>>       > Coleen
> >>>       >
> >>>       > On 10/9/19 5:12 AM, Liu Xin wrote:
> >>>       >> Hi, Reviewers,
> >>>       >>
> >>>       >> Could you review this webrev?
> >>>       >> https://cr.openjdk.java.net/~xliu/8165056/webrev/
> >>>       >> JBS: https://bugs.openjdk.java.net/browse/JDK-8165056
> >>>       >>
> >>>       >> The change is straightforward. Those 3 files below have been
> >> merged
> >>>       >> into compilationPolicy.hpp/cpp.
> >>>       >>
> >>>       >> simpleThresholdPolicy.cpp
> >>>       >> simpleThresholdPolicy.hpp
> >>>       >> simpleThresholdPolicy.inline.hpp
> >>>       >>
> >>>       >> I ran hotspot/compiler tests and it's clear.
> >>>       >>
> >>>       >> thanks,
> >>>       >> --lx
> >>>       >
> >>>
>
>