RFR(XS): 8232151: Minimal VM build broken after JDK-8232050

David Holmes david.holmes at oracle.com
Fri Oct 11 06:58:11 UTC 2019


Hi Jie,

Fix looks good. Sorry about the breakage. I thought we still had one 
test build of Minimal VM in our CI but it seems not. :(

Thanks,
David

On 11/10/2019 1:10 pm, Jie Fu wrote:
> Hi all,
> 
> Could you please review the following fix?
> 
> JBS:    https://bugs.openjdk.java.net/browse/JDK-8232151
> Webrev: http://cr.openjdk.java.net/~jiefu/8232151/webrev.00/
> 
> The patch just added #include "oops/klass.inline.hpp" in the following 
> cpps:
>   - ./sparc/sharedRuntime_sparc.cpp
>   - ./s390/sharedRuntime_s390.cpp
>   - ./ppc/sharedRuntime_ppc.cpp
>   - ./arm/sharedRuntime_arm.cpp
>   - ./x86/sharedRuntime_x86_64.cpp
>   - ./x86/sharedRuntime_x86_32.cpp
>   - ./aarch64/sharedRuntime_aarch64.cpp
> 
> Testing:
>    Build tests for {minimal-release, server-fastdebug, server-release, 
> zero-release} on Linux/x64.
>    Please note that to fully build minimal-release, one more fix for 
> JDK-8232083 is needed [1].
> 
> Thanks a lot.
> Best regards,
> Jie
> 
> [1] http://cr.openjdk.java.net/~jiefu/8232083/webrev.00/
> 
> 


More information about the hotspot-runtime-dev mailing list