RFR(s): 8218543: ThreadsList handling during error reporting can crash

Robbin Ehn robbin.ehn at oracle.com
Mon Oct 14 06:58:20 UTC 2019


Thanks David!

/Robbin

On 2019-10-12 01:23, David Holmes wrote:
> LGTM!
> 
> Thanks Robbin,
> 
> David
> 
> On 11/10/2019 9:08 pm, Robbin Ehn wrote:
>> Hi all, please review.
>>
>> Issue:
>> https://bugs.openjdk.java.net/browse/JDK-8218543
>> Changeset:
>> http://cr.openjdk.java.net/~rehn/8218543/v1/webrev/index.html
>>
>> We avoid the assert and let the error reporting use the ThreadsList in an 
>> unsafe way. More discussion in issue.
>>
>> Note that there was an get_first_error_tid(), but for some reason direct 
>> access to that field with friend was used. I change that to use the get method 
>> and renamed the field following private _ naming convention.
>>
>> Passes t1-2
>>
>> Thanks Robbin


More information about the hotspot-runtime-dev mailing list