RFR: 8232211: Remove dead code from os.hpp|cpp

Claes Redestad claes.redestad at oracle.com
Tue Oct 15 13:24:32 UTC 2019


On 2019-10-15 15:12, Daniel D. Daugherty wrote:
> On 10/15/19 8:28 AM, Claes Redestad wrote:
>> Hi,
>>
>> feel free to review this patch which simply removes a number of
>> dead and/or effectively unused methods from our os interface
>>
>> Webrev: http://cr.openjdk.java.net/~redestad/8232211/open.00/
> 
> src/hotspot/os/aix/os_aix.cpp
>      No comments.
> 
> src/hotspot/os/aix/os_aix.inline.hpp
>      No comments.
> 
> src/hotspot/os/bsd/os_bsd.cpp
>      No comments.
> 
> src/hotspot/os/bsd/os_bsd.inline.hpp
>      No comments.
> 
> src/hotspot/os/linux/os_linux.cpp
>      No comments.
> 
> src/hotspot/os/linux/os_linux.hpp
>      No comments.
> 
> src/hotspot/os/linux/os_linux.inline.hpp
>      No comments.
> 
> src/hotspot/os/posix/os_posix.cpp
>      No comments.
> 
> src/hotspot/os/solaris/os_solaris.cpp
>      Wow. Haven't seen that code in years.
> 
> src/hotspot/os/solaris/os_solaris.hpp
>      No comments.
> 
> src/hotspot/os/solaris/os_solaris.inline.hpp
>      No comments.
> 
> src/hotspot/os/windows/os_windows.cpp
>      No comments.
> 
> src/hotspot/os/windows/os_windows.inline.hpp
>      No comments.
> 
> src/hotspot/os_cpu/solaris_sparc/os_solaris_sparc.cpp
>      No comments.
> 
> src/hotspot/share/gc/g1/g1CollectedHeap.cpp
>      No comments.
> 
> src/hotspot/share/runtime/os.hpp
>      is_suspend_request() is a bit of a surprise, but okay.
> 
> Thumbs up.

Thanks for reviewing, Dan!

/Claes


More information about the hotspot-runtime-dev mailing list