RFR: 8232571: Add missing SIGINFO signal
Roger Riggs
roger.riggs at oracle.com
Mon Oct 21 03:43:03 UTC 2019
Hi,
If I understand correctly SIGINFO is only defined on OSX/BSD and
would not be implemented on any other other OS.
SIGINFO is added to a list of signals that are only included if the OS
is OSX.
(See line 166).
A bit more test code would be needed to verify it was NOT implemented on
other platforms.
It could be added to the posixNonOSXSignals list with:
{"INFO", IsSupported.NO, CanRegister.NO, CanRaise.NO, Invoked.NO},
(And some testing)
+ Copyright.
LGTM
Roger
On 10/20/19 7:10 PM, David Holmes wrote:
> Hi Benoit,
>
> On 19/10/2019 1:27 am, Benoit Daloze wrote:
>> Hello,
>>
>> Please review the following fix for
>> https://bugs.openjdk.java.net/browse/JDK-8232571
>>
>> In short, new sun.misc.Signal("INFO") throws IllegalArgumentException
>> on JDK11+
>> due to the signal not being in the known signal list. This is a
>> regression, it worked fine in JDK8.
>>
>> I attach a patch to fix this,.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8232571
>
> The functional change seems fine to restore support for SIGINFO. I'm
> still a bit perplexed as to when exactly it got removed. :)
>
> I don't understand how the new test can pass on any platform except
> BSD/OSX ?
>
> Please update the copyright year in
> test/jdk/sun/misc/SunMiscSignalTest.java.
>
> Thanks,
> David
> -----
>
>> Thanks,
>> Benoit Daloze
More information about the hotspot-runtime-dev
mailing list