RFR: 8232613: Move Object.registerNatives into HotSpot

[coleen.phillimore at oracle.com]

Hi, 01 looks good but I have another special request.  The block of code 
in systemDictionary knows too much about java_lang_Object.

Can you add a class java_lang_Object (to the top) of javaClasses.hpp, 
and put this code in javaClasses.cpp?

I didn't like the original code in systemDictionary because it seems to 
be used as a kitchen sink of code we don't know what else to do with.  
One could probably make the same argument with other files though.

Thanks,
Coleen

On 10/22/19 7:13 AM, Claes Redestad wrote:
>
>
> On 2019-10-22 13:05, Andrew Dinn wrote:
>> On 22/10/2019 12:05, Claes Redestad wrote:
>>> On 2019-10-22 12:44, Andrew Dinn wrote:
>>>> Why not leave it void?
>>>
>>> I guess:
>>>
>>> http://cr.openjdk.java.net/~redestad/8232613/open.02/
>> Ship it ;-)
>
> No wait, I missed the use in jni.cpp where the bool return is actually
> used. I ignored it in systemDict since when I got an exception there
> (by misspelling a name or using the wrong signature) the exception
> bubbles up and crashes the VM.
>
> Perhaps this could be reworked to remove the bool cleanly, but let's 
> go back to open.01 and move that cleanup to a follow-up.
>
> /Claes
>
>
>