RFR[T]: 8232887: Remove SystemDictionary::has_checkPackageAccess

[Lois Foltan]

On 10/23/2019 9:32 AM, Claes Redestad wrote:
> Hi Lois,
>
> On 2019-10-23 15:25, Lois Foltan wrote:
>> On 10/23/2019 9:09 AM, Claes Redestad wrote:
>>> Hi,
>>>
>>> has_checkPackageAccess appears to be a remnant from the hsx days, so I
>>> think it's safe to remove it at this point.
>>>
>>> Bug:    https://bugs.openjdk.java.net/browse/JDK-8232887
>>> Webrev: http://cr.openjdk.java.net/~redestad/8232887/open.00/
>>>
>>> Testing: tier1-2
>>>
>>> Thanks!
>>>
>>> /Claes
>>
>> Hi Claes,
>>
>> Looks good.  Can you remove the checkPackageAccess_name from 
>> vmSymbols.hpp as well?  There are also some comments within 
>> prims/jvm.cpp that indicate it's the VM's responsibility to call 
>> checkPackageAccess that should be cleaned up as well.
>
> We still need to do the upcalls to ClassLoader.checkPackageAccess,
> just that we do so unconditionally.
>
> That is: This patch only removes the hsx-related conditional checking of
> whether or not that method exists.

You are correct, I read it as if you were removing the call.  Thanks for 
the explanation!  I'm good with the change.
Lois

>
> Thanks!
>
> /Claes