RFR: 8231953: Wrong assumption in assertion in oop::register_oop

[coleen.phillimore at oracle.com]

I'll sponsor it if you commit it locally and send me the hg export patch.
thanks,
Coleen

On 10/23/19 7:53 AM, christoph.goettschkes at microdoc.com wrote:
> Hi Boris,
>
> since no one else responded to the RFR, is the review of Coleen enough for
> you to push the changeset into the repository?
> If so, could you please do it for me?
> If not, how should we proceed?
>
> Thanks, Christoph
>
> "hotspot-runtime-dev" <hotspot-runtime-dev-bounces at openjdk.java.net> wrote
> on 2019-10-15 09:33:20:
>
>> From: christoph.goettschkes at microdoc.com
>> To: hotspot-runtime-dev at openjdk.java.net
>> Date: 2019-10-15 09:34
>> Subject: Re: RFR: 8231953: Wrong assumption in assertion in
> oop::register_oop
>> Sent by: "hotspot-runtime-dev"
> <hotspot-runtime-dev-bounces at openjdk.java.net>
>> Thanks for your feedback Coleen,
>>
>> Does some else have any feedback or can I ask Boris to push the
> changeset
>> into the repository?
>>
>> -- Christoph
>>
>> "hotspot-runtime-dev" <hotspot-runtime-dev-bounces at openjdk.java.net>
> wrote
>> on 2019-10-10 16:50:58:
>>
>>> From: coleen.phillimore at oracle.com
>>> To: hotspot-runtime-dev at openjdk.java.net
>>> Date: 2019-10-10 16:53
>>> Subject: Re: RFR: 8231953: Wrong assumption in assertion in
>> oop::register_oop
>>> Sent by: "hotspot-runtime-dev"
>> <hotspot-runtime-dev-bounces at openjdk.java.net>
>>> This seems fine to me.  The pc was only there to help with debugging.
>>> Coleen
>>>
>>> On 10/10/19 10:28 AM, christoph.goettschkes at microdoc.com wrote:
>>>> Hi,
>>>>
>>>> please review the following changeset. This patch makes the
>>>> CheckUnhandledOops feature work on 32-bit ARM platforms. On this
>> platform,
>>>> the os::current_frame() function does not return a valid frame in
>> thumb
>>>> mode [1]. I removed the failing assertion, since it does not hold on
>> all
>>>> supported platforms. I didn't want to introduce architecture
> specific
>> code
>>>> into that feature, just for an assertion.
>>>>
>>>> This fixes the hotspot tier1 test
>>>> "runtime/CheckUnhandledOops/TestOutOfMemory.java" mentioned in the
>> issue.
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8231953
>>>> Webrev: https://cr.openjdk.java.net/~bulasevich/8231953/webrev.00/
>>>>
>>>> Thanks,
>>>> Christoph
>>>>
>>>> [1]
>>>>
> https://hg.openjdk.java.net/jdk/jdk/file/30a9612a657d/src/hotspot/os_cpu/
>>> linux_arm/os_linux_arm.cpp#l224