RFR 8232890: Remove bad Code attribute parsing code

Harold Seigel harold.seigel at oracle.com
Thu Oct 24 14:49:23 UTC 2019


Thanks Lois!  And thanks for reviewing the CSR.

Harold

On 10/23/2019 6:25 PM, Lois Foltan wrote:
> Hi Harold,
>
> +1, code looks good.  I agree it does need a CSR request.
>
> Thanks,
> Lois
>
> On 10/23/2019 6:18 PM, David Holmes wrote:
>> Hi Harold,
>>
>> On 24/10/2019 8:14 am, Harold Seigel wrote:
>>> Hi,
>>>
>>> Please review this JDK-14 fix to remove obsolete parsing of the 
>>> first few fields of the method Code attribute.  Details are in the bug.
>>>
>>> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8232890/webrev/
>>
>> Code changes seem fine.
>>
>> This change in behaviour will need a CSR request.
>>
>> Thanks,
>> David
>>
>>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8232890
>>>
>>> The fix was regression tested by running Mach5 tiers 1 and 2 tests 
>>> and builds on Linux-x64, Solaris, Windows, and Mac OS X, by running 
>>> Mach5 tiers 3-5 tests on Linux-x64, and JCK lang and VM tests on 
>>> Linux-x64.
>>>
>>> Thanks, Harold
>>>
>


More information about the hotspot-runtime-dev mailing list