RFR JDK-8232724: Remove indirection with calling JNU_NewStringPlatform

Langer, Christoph christoph.langer at sap.com
Wed Oct 30 14:15:15 UTC 2019


Sure. Thanks, Alexey.

> -----Original Message-----
> From: Alexey Ivanov <alexey.ivanov at oracle.com>
> Sent: Mittwoch, 30. Oktober 2019 14:22
> To: Langer, Christoph <christoph.langer at sap.com>; David Holmes
> <david.holmes at oracle.com>; core-libs <core-libs-dev at openjdk.java.net>;
> hotspot-runtime <hotspot-runtime-dev at openjdk.java.net>
> Cc: Claes Redestad <claes.redestad at oracle.com>
> Subject: Re: RFR JDK-8232724: Remove indirection with calling
> JNU_NewStringPlatform
> 
> Thank you, David and Christoph, for your reviews.
> 
> I'll update the copyright year before the push if you don't mind.
> 
> Regards,
> Alexey
> 
> On 30/10/2019 09:05, Langer, Christoph wrote:
> > +1
> >
> > You'll have to update the copyright years in the jni_util files.
> >
> > Cheers
> > Christoph
> >
> >> -----Original Message-----
> >> From: David Holmes <david.holmes at oracle.com>
> >> Sent: Mittwoch, 30. Oktober 2019 05:29
> >> To: Alexey Ivanov <alexey.ivanov at oracle.com>; core-libs <core-libs-
> >> dev at openjdk.java.net>; hotspot-runtime <hotspot-runtime-
> >> dev at openjdk.java.net>; Langer, Christoph <christoph.langer at sap.com>
> >> Cc: Claes Redestad <claes.redestad at oracle.com>
> >> Subject: Re: RFR JDK-8232724: Remove indirection with calling
> >> JNU_NewStringPlatform
> >>
> >> LGTM.
> >>
> >> Thanks,
> >> David
> >>
> >> On 30/10/2019 1:04 am, Alexey Ivanov wrote:
> >>> Hi David, Christoph,
> >>>
> >>> Thank you for your reviews.
> >>>
> >>> On 29/10/2019 07:49, David Holmes wrote:
> >>>>> Shall I remove one of them? The one in jvm.h because it's unused?
> >>>> Yes please remove the unused one in jvm.h.
> >>> The updated webrev:
> >>> http://cr.openjdk.java.net/~aivanov/8232724/webrev.01/
> >>>
> >>> --
> >>> Regards,
> >>> Alexey



More information about the hotspot-runtime-dev mailing list