RFR(xs) 8186988: use log_warning() and log_error() instead of tty->print_cr for CDS warning and error messages

[Thomas Stüfe]

.. another difference is of course that the warnings will now appear in
whatever the sink is for UL is (e.g. UL log file) while before the patch
they had always been printed unconditionally to stdout regardless of UL
settings.

But I do not know whether this matters or not, so from my point of view
this is fine.

 Cheers, Thomas




On Wed, Sep 11, 2019 at 8:53 PM Ioi Lam <ioi.lam at oracle.com> wrote:

> I agree that as long as the message itself it unchanged, having the
> extra UL decoration should be OK.
>
>
> For the "Preload Warning", I think it's prudent to keep it. I withdraw
> my request to remove it.
>
> Thanks
> - Ioi
>
>
> On 9/11/2019 11:25 AM, Calvin Cheung wrote:
> > Hi Thomas,
> >
> > Thanks for your review.
> >
> > On 9/11/19 10:41 AM, Thomas Stüfe wrote:
> >> Hi Calvin,
> >>
> >> looks okay. This will cause the messages to be printed with UL
> >> decorations, right?
> >
> > Yes, after the change, an error message would look like:
> >
> > [0.337s][error][cds] Error: non-empty directory
> > '/scratch/jtreg_test/JTwork/scratch/0/mods/com.simple/
> >
> > Before change:
> >
> > Error: non-empty directory
> > '/scratch/jtreg_test/JTwork/scratch/21/mods/com.simple/
> >
> >> Is that okay or could this cause backward compatibility problems?
> >
> > Probably okay as long as the message stays the same.
> >
> > thanks,
> >
> > Calvin
> >
> >>
> >> Cheers, Thomas
> >>
> >> On Wed, Sep 11, 2019 at 6:29 PM Calvin Cheung
> >> <calvin.cheung at oracle.com <mailto:calvin.cheung at oracle.com>> wrote:
> >>
> >>     bug: https://bugs.openjdk.java.net/browse/JDK-8186988
> >>
> >>     webrev: http://cr.openjdk.java.net/~ccheung/8186988/webrev.00/
> >>
> >>     Please review this simple change for replacing the use of
> >>     tty->print_cr
> >>     with log_waring(cds) for CDS warning messages and with
> >> log_error(cds)
> >>     for error messages.
> >>
> >>     Ran tier1 - 3 testing.
> >>
> >>     thanks,
> >>
> >>     Calvin
> >>
>
>