RFR (XXS) 8231201: hs_err should print coalesced safepoint operations in Events section

Aleksey Shipilev shade at redhat.com
Wed Sep 18 20:02:14 UTC 2019


On 9/18/19 9:57 PM, Hohensee, Paul wrote:
> Any reason not to make the EventMark message identical to the log message? I.e., in the EventMark
> message change "Executing" to "Evaluating".
> 

Gotcha! That's exactly why I put the webrev in. See the existing line for event saying "Executing":
 536       EventMark em("Executing VM operation: %s", vm_operation()->name());

...and log_debug(vmthread) says "Evaluating". The patch matches the other EventMark.

> On 9/18/19, 12:48 PM, "Aleksey Shipilev" <shade at redhat.com> wrote:
> https://cr.openjdk.java.net/~shade/8231201/webrev.01/
> 
> Little debugging aid here. See examples in the bug. The patch is one-liner, but webrev is
> provided to give reviewers a better context, for example to compare with other EventMark and 
> log_debug(vmthread) statements.

-- 
Thanks,
-Aleksey



More information about the hotspot-runtime-dev mailing list