RFR(xs): 8229778: TestJstatdDefaults.java failed due to "fatal error: LEAF method calling lock?"

David Holmes david.holmes at oracle.com
Mon Sep 23 12:27:48 UTC 2019


Hi Robbin,

On 23/09/2019 10:14 pm, Robbin Ehn wrote:
> Hi all, please review.
> 
> Threads_lock is an always safepoint checked lock.
> We can end up in block_if_vm_exited in all sorts of states.
> But only after final safepoint started, so we just set state in vm 
> before locking it.
> 
> Issue:
> https://bugs.openjdk.java.net/browse/JDK-8229778
> 
> Change-set:
> http://cr.openjdk.java.net/~rehn/8229778/webrev/

!     // proper tranisition, but it happens after the final safepoint 
have begun.

s/tranisition/transition/
s/have/has/

otherwise fix is fine.

Thanks,
David
-----

> Passes t1-2, x64 svc_tools and TestJstatdDefaults.
> 
> Thanks, Robbin


More information about the hotspot-runtime-dev mailing list