RFR(xs): 8229778: TestJstatdDefaults.java failed due to "fatal error: LEAF method calling lock?"

Robbin Ehn robbin.ehn at oracle.com
Mon Sep 23 13:13:42 UTC 2019


Thanks Dan!

/Robbin

On 9/23/19 3:12 PM, Daniel D. Daugherty wrote:
> On 9/23/19 8:14 AM, Robbin Ehn wrote:
>> Hi all, please review.
>>
>> Threads_lock is an always safepoint checked lock.
>> We can end up in block_if_vm_exited in all sorts of states.
>> But only after final safepoint started, so we just set state in vm before 
>> locking it.
>>
>> Issue:
>> https://bugs.openjdk.java.net/browse/JDK-8229778
>>
>> Change-set:
>> http://cr.openjdk.java.net/~rehn/8229778/webrev/
> 
> src/hotspot/share/runtime/thread.cpp
>      No comment (modulo the typos already pointed out).
> 
> Thumbs up!
> 
> Dan
> 
>>
>> Passes t1-2, x64 svc_tools and TestJstatdDefaults.
>>
>> Thanks, Robbin
> 


More information about the hotspot-runtime-dev mailing list