RFR[T]: 8242003: Remove CallInfo::_selected_klass

Daniel D. Daugherty daniel.daugherty at oracle.com
Wed Apr 1 16:47:10 UTC 2020



On 4/1/20 12:33 PM, Claes Redestad wrote:
> With bug link: https://bugs.openjdk.java.net/browse/JDK-8242003
>
> On 2020-04-01 18:24, Claes Redestad wrote:
>> Hi,
>>
>> CallInfo::_selected_klass is unused, and can be removed.
>>
>> Webrev: 
>> http://cr.openjdk.java.net/~redestad/scratch/link_selected_klass.00/

src/hotspot/share/interpreter/linkResolver.cpp
     No comments.

src/hotspot/share/interpreter/linkResolver.hpp
     old L108   int          call_index() const                { return 
_call_index; }
         I wasn't expecting this deletion, but it does appear to be an
         unused accessor (code uses direct field access instead).


There's no build/test info supplied, but I'm assuming you've run it
thru minimally Tier1.

The removal appears to be clean, but the obvious question is why is
the field there and is there a bug that should be using that field
and is using something else instead...

Thumbs up if you've done a Tier1 build and test cycle and if you're
sure that the field isn't supposed to be used.

Dan


>>
>> Thanks!
>>
>> /Claes



More information about the hotspot-runtime-dev mailing list