RFR 15 8225319: Remove the RMI static stub compiler rmic
Roger Riggs
Roger.Riggs at oracle.com
Mon Apr 6 15:25:59 UTC 2020
Hi Amy,
Thanks for looking in places I didn't grep for rmic references.
Hotspot for cds and langtools for javadoc.
The webrev is covers just the new changes but I will merge them before
the push.
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-remove-rmic-8225319-misc/
Thanks, Roger
On 4/6/20 8:28 AM, Amy Lu wrote:
> Hi, Roger
>
> I noticed some other minor cleanup needed, will they be included in
> this fix, or separately in the future?
>
> 1. test/jdk/TEST.groups
> To remove `sun/tools/java` from core_tools and svc_tools group. (The
> only one test under `sun/tools/java` got removed in this patch.)
>
> 2. doc/building.md and doc/building.html, both mention rmic tool.
>
> 3. langtools tests
> module:jdk.rmic
> ./test/langtools/jdk/javadoc/doclet/testModules/jdk/element-list
> new String[] {"jdk.compiler", "jdk.rmic"},
> new String[] {"jdk.compiler", "jdk.javadoc",
> "jdk.rmic"},
> new String[] {"java.compiler", "jdk.compiler",
> "jdk.rmic"},
> new String[] {"java.compiler", "jdk.compiler",
> "jdk.javadoc", "jdk.rmic"},
> ./test/langtools/tools/jdeps/modules/InverseDeps.java
>
> 4. hotspot tests
> * @summary run CTW for all classes from jdk.rmic module
> * @modules jdk.rmic
> * @run driver/timeout=7200 sun.hotspot.tools.ctw.CtwRunner
> modules:jdk.rmic
> ./test/hotspot/jtreg/applications/ctw/modules/jdk_rmic.java
> "sun/rmi/rmic/Main",
> ./test/hotspot/jtreg/runtime/cds/appcds/ProtectionDomain.java
> // sun.rmi.rmic.Main (testcase 4),
> {"Loading non-shared app module class first",
> "sun.rmi.rmic",
> "sun.rmi.rmic.RMIGenerator", "sun.rmi.rmic.Main"},
> ./test/hotspot/jtreg/runtime/cds/appcds/test-classes/JimageClassPackage.java
>
> "sun/rmi/rmic/Main",
> ./test/hotspot/jtreg/runtime/cds/appcds/SharedPackages.java
>
> Thanks,
> Amy
>
>
> On 4/3/20 11:43 PM, Roger Riggs wrote:
>> Please review the CSR[1] and changes to remove the RMI static stub
>> compiler (rmic).
>> RMIC was deprecated for removal in JDK 13 [3].
>>
>> The components modified are:
>> - remove the jdk.rmic module
>> - remove the jdk.rmic man page
>> - remove all tests of rmic or relying on rmic
>> - update or remove makefiles to remove references and dependencies
>> on rmic
>> - update source files in java.rmi module to remove extraneous
>> references to rmic
>>
>> Wevrev:
>> http://cr.openjdk.java.net/~rriggs/webrev-remove-rmic-8225319
>>
>> Thanks, Roger
>>
>> [1] CSR:
>> https://bugs.openjdk.java.net/browse/JDK-8242049
>>
>> [2] Issue:
>> https://bugs.openjdk.java.net/browse/JDK-8225319
>>
>> [3] Deprecate rmic for removal
>> https://bugs.openjdk.java.net/browse/JDK-8217412
>>
>
More information about the hotspot-runtime-dev
mailing list