RFR(XXS): 8242485: Null _file checking in fileStream::flush()

Yasumasa Suenaga suenaga at oss.nttdata.com
Sat Apr 11 01:22:25 UTC 2020


Hi Denghui,

null check lacks in other place too.
Can you fix it?

   http://hg.openjdk.java.net/jdk/jdk/file/97d5d0cd1085/src/hotspot/share/utilities/ostream.cpp#l554


Thanks,

Yasumasa


On 2020/04/10 21:34, Denghui Dong wrote:
> Hi team,
> 
> Could you please review this small patch?
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8242485
> webrev: http://cr.openjdk.java.net/~ddong/8242485/webrev.00/
> 
> I found the method "fileStream::flush()" lacks null check before fflush  which will cause
> all open output streams are flushed by fflush() if _file is NULL.
> 
> Thanks,
> Denghui Dong
> 


More information about the hotspot-runtime-dev mailing list