RFR 8242921: test/hotspot/jtreg/runtime/CompactStrings/TestMethodNames.java uses nashorn script engine

Harold Seigel harold.seigel at oracle.com
Mon Apr 27 13:12:43 UTC 2020

Thanks Lois.

I'll add the comment before I push the change.


On 4/27/2020 9:11 AM, Lois Foltan wrote:
> On 4/27/2020 8:50 AM, Harold Seigel wrote:
>> Hi,
>> Please review this small change to test TestMethodNames.java to no 
>> longer use nashorn to generate nonstandard method names. Instead, the 
>> names are hard-coded in a new .jcod file.
>> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8242921/webrev/
>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8242921
>> The test was run using Mach5 tiers 1-3 to check that it passed on 
>> multiple platforms and with multiple flags.
>> Thanks, Harold
> Looks good Harold!  Minor nit, please consider putting a comment at 
> the top of the .jcod files containing the method names since the calls 
> to the eval method, which also have the side effect of showing the 
> names, are being removed.
> Thanks,
> Lois

More information about the hotspot-runtime-dev mailing list