RFR(T) : 8243944 : use SkippedException and @requires in runtime/memory/ReadFromNoaccessArea.java test

Igor Ignatyev igor.ignatyev at oracle.com
Wed Apr 29 04:24:52 UTC 2020


Yumin,

thanks for your quick review, pushed.

-- Igor

> On Apr 28, 2020, at 9:01 PM, Yumin Qi <yumin.qi at oracle.com> wrote:
> 
> Looks good!
> 
> Thanks
> Yumin
> 
> On 4/28/20 8:44 PM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8243944/webrev.01
>>> 8 lines changed: 2 ins; 5 del; 1 mod;
>> HI all,
>> 
>> could you please review this trivial patch?
>> from JBS:
>>> runtime/memory/ReadFromNoaccessArea.java test can be run only on 64 bits platform and currently exits if it's not the case; this test also doesn't conduct any verification if a forked JVM prints 'WB_ReadFromNoaccessArea method is useless' so SkippedException can be used to signal that the test wasn't really performed.
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8243944
>> webrev: http://cr.openjdk.java.net/~iignatyev//8243944/webrev.01
>> testing: runtime/memory/ReadFromNoaccessArea.java
>> 
>> Thanks,
>> -- Igor
> 



More information about the hotspot-runtime-dev mailing list