RFR(T) : 8243945 : use driver mode in runtime tests

[gerard ziemski]

hi Igor,

Looks good, thank you for cleaning so many files!

On 4/29/20 2:19 PM, Igor Ignatyev wrote:
> http://cr.openjdk.java.net/~iignatyev//8243945/webrev.00/
>> 143 lines changed: 46 ins; 0 del; 97 mod;
> Hi all,
>
> could you please review the trivial patch which updates 109 runtime tests to use driver mode?
>
> in most cases, the changes are as straightforward as 's/main/driver/', other changes are:
>   - runtime/InvocationTests tests throw an exception instead of calling System.exit
>   - runtime/condy/CondyLDCTest.java passes "-Xverify:all", although the test didn't do that before, it seems it was intended, in any case it won't cause any harm
>   - in runtime/records/ignoreRecordAttribute.java, indent of jtreg test description block was fixed.
>
> webrev: http://cr.openjdk.java.net/~iignatyev//8243945/webrev.00
> (for the sake of reviewers, copyright year changes are omitted, the final patch changes years in )
> JBS: https://bugs.openjdk.java.net/browse/JDK-8243945
> testing: test/hotspot/jtreg/runtime

How did you determine which tests need to be updated to use driver mode? 
Can there be more?

In "ProtectionDomainCacheTest" we used to have extra arguments, i.e. 
"policy=test.policy -Djava.security.manager ProtectionDomainCacheTest", 
but now we don't?

In "NestedThreadsListHandleInErrorHandlingTest" we used to have 
"-XX:+UnlockDiagnosticVMOptions -XX:+EnableThreadSMRStatistics", but now 
we don't?

In "ThreadsListHandleInErrorHandlingTest" we used to have 
"-XX:+UnlockDiagnosticVMOptions -XX:+EnableThreadSMRStatistics", but now 
we don't?

In "CondyNewInvokeSpecialTest" we used to have "-Xverify:all", but now 
we don't?

In "ignoreRecordAttribute" we used to have "--enable-preview", but now 
we don't?


cheers