RFR(xxs): 8250911: [windows] os::pd_map_memory() error detection broken

[Ioi Lam]

Hi Thomas,

Looks good to me. Thanks for fixing this.

Thanks
- Ioi

On 7/31/20 10:22 PM, Thomas Stüfe wrote:
> Hi,
>
> While trying to find out why
> https://bugs.openjdk.java.net/browse/JDK-8249943 consistently fails at SAP
> nightlies, I stumbled upon a small zero-day (AFAICS) bug in the Windows
> version of os::pd_map_memory().
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8250911
> webrev:
> http://cr.openjdk.java.net/~stuefe/webrevs/8250911---windows--os--pd_map_memory-error-detection-broken/webrev.00/webrev/
>
> While this is annoying I do not expect fixing this bug will shake loose
> many follow up bugs. Currently, if the CreateFile call fails but we don't
> get it one of the follow up system calls will fail. All this fix provides
> is better error analysis.
>
> Thanks, Thomas