RFR(xxs): 8250911: [windows] os::pd_map_memory() error detection broken

[Thomas Stüfe]

Thanks Kim.

On Sat, Aug 1, 2020, 11:58 Kim Barrett <kim.barrett at oracle.com> wrote:

> > On Aug 1, 2020, at 1:22 AM, Thomas Stüfe <thomas.stuefe at gmail.com>
> wrote:
> >
> > Hi,
> >
> > While trying to find out why
> > https://bugs.openjdk.java.net/browse/JDK-8249943 consistently fails at
> SAP
> > nightlies, I stumbled upon a small zero-day (AFAICS) bug in the Windows
> > version of os::pd_map_memory().
> >
> > JBS: https://bugs.openjdk.java.net/browse/JDK-8250911
> > webrev:
> >
> http://cr.openjdk.java.net/~stuefe/webrevs/8250911---windows--os--pd_map_memory-error-detection-broken/webrev.00/webrev/
> >
> > While this is annoying I do not expect fixing this bug will shake loose
> > many follow up bugs. Currently, if the CreateFile call fails but we don't
> > get it one of the follow up system calls will fail. All this fix provides
> > is better error analysis.
> >
> > Thanks, Thomas
>
> Looks good.
>
>