RFR: 8250636: iso8601_time returns incorrect offset part on MacOS

[Dmitry Cherepanov]

Hi David,

On 03.08.2020 10:53, David Holmes wrote:
> Hi Dmitry,
>
> On 31/07/2020 8:29 pm, Dmitry Cherepanov wrote:
>> Hi Gerard,
>>
>> Thanks for reviewing this, moving the logic of get_timezone to
>> iso8601_time looks good to me too.
>> Here's an updated webrev
>> http://cr.openjdk.java.net/~dcherepanov/8250636/webrev.v4/
>
> This version also looks good to me. But now I see all the code clearly in one place I have to wonder why we are not using tm_gmtoff on all platforms except Windows? That would simplify the logic even further.
>
> That goes beyond fixing the current actual bug though so I'll leave that choice to you.

Thanks for the suggestion. This change would not work on Solaris. But given the removal of Solaris port, I also see no other reasons why not to use tm_gmtoff on platforms except Windows.

Updated webrev: http://cr.openjdk.java.net/~dcherepanov/8250636/webrev.v5/
Jdk-submit testing passed with this change

Thanks,

Dmitry