RFR: 8165404: AArch64: Implement SHA512 accelerator/intrinsic
Andrew Haley
aph at redhat.com
Tue Aug 4 10:26:59 UTC 2020
On 8/3/20 2:18 AM, Yangfei (Felix) wrote:
> OK. I simply comment out the following code changes in vm_version_aarch64.cpp:
>
> 393 if (UseSHA && (auxv & HWCAP_SHA512)) {
> 394 // Do not auto-enable UseSHA512Intrinsics until it has been fully tested on hardware
> 395 // if (FLAG_IS_DEFAULT(UseSHA512Intrinsics)) {
> 396 // FLAG_SET_DEFAULT(UseSHA512Intrinsics, true);
> 397 // }
> 398 } else if (UseSHA512Intrinsics) {
>
> Once this has been fully tested on real hardware, it will be easy to auto-enable.
>
> New webrev: http://cr.openjdk.java.net/~fyang/8165404/webrev.01/
Looks good, thanks.
My apologies, there is another thing I should have mentioned: please add
test cases for the new instructions to aarch64-asmtest.py and regenerate
the code between
// BEGIN Generated code -- do not edit
// Generated by aarch64-asmtest.py
and
// END Generated code -- do not edit
I'm trying to be more strict about making sure all of the instructions get
tested.
--
Andrew Haley (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
More information about the hotspot-runtime-dev
mailing list