RFR: 8251031: Some vmTestbase/nsk/monitoring/RuntimeMXBean tests fail with hostnames starting from digits(Internet mail)

[jiefu(傅杰)]

Thanks David for your review.


Best regards,

Jie


________________________________
From: David Holmes <david.holmes at oracle.com>
Sent: Tuesday, August 4, 2020 6:51 PM
To: jiefu(傅杰); hotspot-runtime-dev at openjdk.java.net
Subject: Re: RFR: 8251031: Some vmTestbase/nsk/monitoring/RuntimeMXBean tests fail with hostnames starting from digits(Internet mail)

Hi Jie,

On 4/08/2020 7:08 pm, jiefu(傅杰) wrote:
> Hi all,
>
> JBS:    https://bugs.openjdk.java.net/browse/JDK-8251031
> Webrev: http://cr.openjdk.java.net/~jiefu/8251031/webrev.00/
>
> Some vmTestbase/nsk/monitoring/RuntimeMXBean tests failed in our test infrastructure.
> The reason is that these tests reject hostnames starting with digits.
>
> However, hostnames starting from digits are actually valid according to RFC1123 [1][2].
> It would be better to fix it.

I don't process regular expressions very well but I can see the addition
of the 0-9 character class in the expression so that appears fine. :)

What I don't understand is why we aren't simply splitting the string at
'@' and taking the pid and hostname directly. (That's somewhat
rhetorical I don't expect you to change the test.)

Thanks,
David
-----

> Thanks a lot.
> Best regards,
> Jie
>
> [1] https://tools.ietf.org/html/rfc1123#page-13
> [2] https://en.wikipedia.org/wiki/Hostname
>