RFR: 8250598: Hyper-V is detected in spite of running on host OS

[Yasumasa Suenaga]

Hi Matthias,
(CC'ed build-dev due to makefile change)

I uploaded new webrev. Could you review it?

   http://cr.openjdk.java.net/~ysuenaga/JDK-8250598/webrev.01/

On 2020/08/05 16:26, Baesken, Matthias wrote:
> Hello,
> 
>>> I also checked the  hserr on another Hyper-V guest and still get the expected " HyperV virtualization detected"   (which is good �� ).
>>>
>>>
>>> However on a host, I would still prefer to get some output (probably different than the guest output now) .
>>
>> What message do you expect? How about "Hyper-V role detected" ?
> 
> Thats okay with me  (I think some people here say "Hyper-V host" so that might be an idea as well).

I said "Hyper-V host" in previous mails, but it is not strictly correct. In Hyper-V, it should be "root partision". However it's a little difficult to understand, so I choose "role" in this place.


>>> Regarding the usage of
>>>
>>> #pragma comment(lib, "wbemuuid.lib")
>>>
>>> This seem to add an additional lib dependency ,  should some people from build/deploy  area comment on this maybe ?
>>> (not saying it is a very bad thing )

I modified libraries.m4.
wbemuuid.lib is needed for WMI call.


Thanks,

Yasumasa


>> We add wbemuuid.lib to make/autoconf/libraries.m4 .
>> I will change it in next webrev, and I will CCing to build-dev on next turn.
> 
> 
> Let's see what they have to say.
> 
> Best regards, Matthias
> 
>