RFR JDK-8251213 [TESTBUG] CDS tests shouldn't write output files into test.classes directory

[Ioi Lam]

Hi Yumin,

Thanks for the review. I actually fixed the repeated name in the test 
stdout/stderr files, but forgot to mention it in the e-mail. The files 
look like this now:

work/runtime/cds/appcds/HelloTest/runtime.cds.appcds.HelloTest.java-0000-dump.stderr
work/runtime/cds/appcds/HelloTest/runtime.cds.appcds.HelloTest.java-0000-dump.stdout
work/runtime/cds/appcds/HelloTest/runtime.cds.appcds.HelloTest.java-0001-exec.stderr
work/runtime/cds/appcds/HelloTest/runtime.cds.appcds.HelloTest.java-0001-exec.stdout


Thanks
- Ioi

On 8/6/20 9:54 AM, Yumin Qi wrote:
> Hi, Ioi
>
>   The change looks good to me.
>
>   The output file name repeats test name in it. This is not related to 
> your change, but think if you can make change to it:
>
> runtime.cds.appcds.cacheObject.OpenArchiveRegion.java-runtime.cds.appcds.cacheObject.OpenArchiveRegion.java-0000-dump.stderr 
>
> runtime.cds.appcds.cacheObject.OpenArchiveRegion.java-runtime.cds.appcds.cacheObject.OpenArchiveRegion.java-0000-dump.stdout 
>
>
>
> Thanks
>
> Yumin
>
>
> On 8/5/20 11:21 PM, Ioi Lam wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8251213
>> http://cr.openjdk.java.net/~iklam/jdk16/8251213-cds-shouldnt-write-test-classes-dir.v01/ 
>>
>>
>> Many of the CDS tests would write output files to the directory
>> given by System.getProperty("test.classes").
>>
>> I changed them to write to the scratch directory, i.e.,
>> System.getProperty("user.dir", "."). This way, it's easier to examine 
>> the
>> output of the tests.
>>
>> Please start the review with CDSTestUtils.java.
>>
>> I validated the change by going to the jtreg work directory and:
>>
>>     $ find $(find . -name classes) -type f | grep -v '[.]class$' | wc -l
>>     0
>>
>> (There used to be a lot of .jsa, .classlist, .stdout, etc).
>>
>> Executed all the tests locally on Linux. Running mach5 tiers1-4.
>>
>> Thanks
>> - Ioi