RFR (xs) 8251209 [TESTBUG] CDS jvmti tests should use "@modules java.instrument"

[David Holmes]

Hi Ioi,

On 7/08/2020 4:25 am, Ioi Lam wrote:
> https://bugs.openjdk.java.net/browse/JDK-8251209
> http://cr.openjdk.java.net/~iklam/jdk16/8251209-cds-jvmti-tests-modules-tag.v01/ 
> 
> 
> Summary -- changed the tests from (mis)using
> 
>   * @requires vm.flavor != "minimal"
> 
> to
> 
>   * @modules java.instrument
> 
> ... to be consistent with other jvmti tests.

That seems like an invalid precondition to me. It would have been 
somewhat valid in the Compact Profiles world when we did not provide 
"java.instrument" in the profiles which supported MinimalVM, but you can 
define a minimal VM in a build that still has all modules available. I 
don't think building the minimal VM makes any changes to the supported 
modules.

Also AIUI the @modules statement simply adds the necessary command-line 
args to use the java.instrument module (if present), it doesn't ensure 
that the listed module has to be present.

David

> Thanks
> - Ioi