RFR: 8251365: Build failure on AIX after 8250636

[Doerr, Martin]

Hi Dmitry,

I have a post submission review: Looks good to me.
Thanks for fixing it quickly.

Best regards,
Martin


> -----Original Message-----
> From: Dmitry Cherepanov <dcherepanov at azul.com>
> Sent: Dienstag, 11. August 2020 13:06
> To: David Holmes <david.holmes at oracle.com>; hotspot-runtime-
> dev at openjdk.java.net; Doerr, Martin <martin.doerr at sap.com>
> Subject: Re: RFR: 8251365: Build failure on AIX after 8250636
> 
> Hi David,
> 
> I'm sorry for pushing this without second review. I will keep that in mind in
> the future.
> In the bug report (https://bugs.openjdk.java.net/browse/JDK-8251365)
> Martin confirmed that AIX now builds with this change.
> 
> Thanks,
> 
> Dmitry
> 
> On 11.08.2020 13:32, David Holmes wrote:
> > Hi Dmitry,
> >
> > This needed a second review before pushing. At a minimum Martin
> needed a chance to verify it on AIX.
> >
> > David
> >
> > On 11/08/2020 11:54 am, David Holmes wrote:
> >> Hi Dmitry,
> >>
> >> I didn't see this when replying to the other thread.
> >>
> >> On 11/08/2020 6:27 am, Dmitry Cherepanov wrote:
> >>> Please review the fix for build failure on AIX. With this change,
> "tm_gmtoff" is used only if _ALLBSD_SOURCE or _GNU_SOURCE is set. In the
> case of AIX, we'll continue to use "timezone".
> >>>
> >>> I'll start jdk-submit testing for this change shortly, unfortunately I do not
> have an AIX machine at hand and would appreciate if someone (with access
> to AIX) could verify that the change fixes AIX build . Thanks in advance.
> >>>
> >>> JBS: https://bugs.openjdk.java.net/browse/JDK-8251365
> >>> Webrev:
> http://cr.openjdk.java.net/~dcherepanov/8251365/webrev.v1/
> >>
> >> This seems okay to me. All the ifdefs are a bit jarring (makes it seem like
> there should be a pd_xxx method underpinning this) but acceptable.
> >>
> >> Thanks,
> >> David
> >>
> >>> Thanks,
> >>>
> >>> Dmitry
> >>>