RFR(S) 8251560 Remove excessive header file inclusion from systemDictionary.hpp and others

[Ioi Lam]

Hi Coleen,

Thanks for the review.

Since the constructors are pretty simple, I moved them from 
systemDictionary.cpp into classLoadInfo.hpp. I also removed the default 
constructor which doesn't seem to be used.

http://cr.openjdk.java.net/~iklam/jdk16/8251560-remove-includes-in-system-dict-etc.v02-delta/

Thanks
- Ioi


On 8/14/20 11:38 AM, Coleen Phillimore wrote:
>
>
> On 8/14/20 2:35 PM, Coleen Phillimore wrote:
>>
>> I really like this change.  It looks like you need a 
>> classLoadInfo.hpp file with the constructors.
> Oops, I mean classLoadInfo.cpp file.
>>
>> Thanks,
>> Coleen
>>
>> On 8/14/20 12:54 PM, Ioi Lam wrote:
>>> https://bugs.openjdk.java.net/browse/JDK-8251560
>>> http://cr.openjdk.java.net/~iklam/jdk16/8251560-remove-includes-in-system-dict-etc.v01/ 
>>>
>>>
>>> Summary:
>>>
>>> I removed a few unnecessary #includes from systemDictionary.hpp, 
>>> signature.hpp, altHashing.hpp and klass.inline.hpp
>>>
>>> Two rarely used classes are moved to a new header file 
>>> classLoadInfo.hpp
>>>
>>> Some non-critical inline functions were moved to cpp files.
>>>
>>> Some cpp files needed to be updated (because they didn't explicitly 
>>> declare dependencies on header files that were transitively included 
>>> by other header files).
>>>
>>> Tested with mach5 tier1 and also local Linux builds (no-pch, minimal 
>>> VM, etc).
>>> Thanks
>>> - Ioi
>>
>