RFR: 8165404: AArch64: Implement SHA512 accelerator/intrinsic
Andrew Haley
aph at redhat.com
Mon Aug 17 15:53:48 UTC 2020
On 17/08/2020 13:01, Yangfei (Felix) wrote:
>> Looks good. If I were editing the Python script I'd also add
>> random.seed(0) so that the generated code doesn't change every time.
> Thanks for the quick reply. Do you mean we need any more change?
> For the purpose for testing the instructions, it might not be a good
> idea to add random.seed(0). This will limit the randomness of the
> register numbers used for each run.
Not really, because we paste the output into assembler.cpp so that we
use the same values every time it runs. I don't think it helps anyone
that we use different random offsets every time the test code is
regenerated.
--
Andrew Haley (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
More information about the hotspot-runtime-dev
mailing list