RFR 8251490: [TESTBUG] The Java thread stack size specified is too small for nsk/stress/stack. Specify at least 448k

[gerard ziemski]

hi Harold,

Thank you for fixing this.


On 8/18/20 12:19 PM, Harold Seigel wrote:
> Hi,
>
> Please review this small change to fix five 
> vmTestbase/nsk/stress/stack tests that are failing in tier5 on Linux 
> AArch64.  The change increases the stack size for three of the tests.  
> Increasing the stack size of the other two tests could result in 
> timeouts on other platforms.  So, those tests were changed to no 
> longer run on AArch64.
>
> Open Webrev: 
> http://cr.openjdk.java.net/~hseigel/bug_8251490/webrev/index.html
>
> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8251490
>
> The change was tested by running the tests as part of mach5 tier5 on 
> Windows, Mac, Linux x64, and Linux AArch64.
>
> Thanks, Harold
>
It looks reasonable to me, but I have some questions:

#1 Does "-eager" really make much difference here? Do you have any 
timing numbers you can provide with and without that flag, just so that 
we know how much it helps?

#2 How did you determine the the 900s timeout? How long does it take for 
a regular, middle of the road machine to execute each test? Do we use 
any slow/low end machines in our testing that could take longer than 
this time out? (I'm worried about that hardcoded time out value if you 
can tell)


cheers