RFR(XS) 8252056 Move DumpRegion/ReadClosure/WriteClosure to archiveUtils.hpp
Ioi Lam
ioi.lam at oracle.com
Thu Aug 20 05:37:01 UTC 2020
On 8/19/20 4:08 PM, Yumin Qi wrote:
> Hi, Ioi
>
> Looks good to me.
>
> One question: with removing of #if INCLUDE_CDS from file
> archiveUtils.cpp, will this file be added to non-CDS build?
>
Hi Yumin,
Thanks for the review.
archiveUtils.cpp is excluded from non-CDS build by the makefiles:
http://hg.openjdk.java.net/jdk/jdk/file/fc8e62b399bd/make/hotspot/lib/JvmFeatures.gmk#l120
Our coding convention has been that "#if INCLUDE_CDS" should be avoided
in such excluded files, to reduce clutter in the code.
Thanks
- Ioi
>
> Thanks
>
> Yumin
>
>
> On 8/19/20 1:47 PM, Ioi Lam wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8252056
>> http://cr.openjdk.java.net/~iklam/jdk16/8252056-move-dump-region-to-archive-utils.v01/
>>
>>
>> Part of CDS code clean up:
>>
>> The classes are currently in metaspaceShared.hpp/cpp, which are too big.
>> It's better to move these utility classes to archiveUtils.cpp/hpp
>>
>> Thanks
>> - Ioi
More information about the hotspot-runtime-dev
mailing list