RFR (urgent, trivial) 8252149: Compilation error after JDK-8252043
Coleen Phillimore
coleen.phillimore at oracle.com
Fri Aug 21 15:23:10 UTC 2020
Thanks Harold!
Coleen
On 8/21/20 11:11 AM, Harold Seigel wrote:
> looks good and trivial.
>
> Harold
>
> On 8/21/2020 11:10 AM, Coleen Phillimore wrote:
>> open webrev at
>> http://cr.openjdk.java.net/~coleenp/2020/8252149.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8252149
>>
>> See bug for details. This is the version I had tested but I thought
>> I'd change it. The first version was better and cross compiles on
>> linux-aarch64.
>> should_clean_metaspace_and_reset has the #if INCLUDE_JVMTI code we
>> need for the cross compilation on linux-aarch64 which uses the
>> minimal configuration. See:
>>
>> bool ClassLoaderDataGraph::should_clean_metaspaces_and_reset() {
>> // Only clean metaspaces after full GC.
>> bool do_cleaning = _safepoint_cleanup_needed;
>> #if INCLUDE_JVMTI
>> do_cleaning = do_cleaning && (_should_clean_deallocate_lists ||
>> InstanceKlass::has_previous_versions());
>> #else
>> do_cleaning = do_cleaning && _should_clean_deallocate_lists;
>> #endif
>> _safepoint_cleanup_needed = false; // reset
>> return do_cleaning;
>> }
>>
>>
>> thanks,
>> Coleen
More information about the hotspot-runtime-dev
mailing list