RFR(S): 8251918: [Graal] Crash in DumpTimeSharedClassInfo::add_verification_constraint

[Ioi Lam]

Looks good to me too.

Thanks
Ioi

> On Aug 21, 2020, at 1:30 PM, calvin.cheung at oracle.com wrote:
> 
> Thanks, Yumin!
> 
>> On 8/21/20 11:51 AM, Yumin Qi wrote:
>> Hi, Calvin
>> 
>>   Looks good.
>> 
>> 
>> Thanks
>> 
>> Yumin
>> 
>>> On 8/21/20 11:22 AM, calvin.cheung at oracle.com wrote:
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8251918
>>> 
>>> webrev: http://cr.openjdk.java.net/~ccheung/jdk16/8251918/webrev.00/
>>> 
>>> After the fix for JDK-8247529, the SystemDictionaryShared::find_or_allocate_info_for(InstanceKlass* k) could return NULL if dynamic CDS dump is in progress.
>>> 
>>> The proposed fix is to do a NULL check on the return value of SystemDictionaryShared::find_or_allocate_info_for().
>>> 
>>> Testing: Tier1 - 4, hs-tier4-graal, hs-tier8-graal
>>> 
>>> thanks,
>>> 
>>> Calvin
>>>