RFR (S) 8244386: convert runtime/Safepoint/AssertSafepointCheckConsistency tests to gtest
Coleen Phillimore
coleen.phillimore at oracle.com
Tue Aug 25 13:19:15 UTC 2020
Thanks Lois!
Coleen
On 8/25/20 9:17 AM, Lois Foltan wrote:
> On 8/25/2020 8:52 AM, Coleen Phillimore wrote:
>>
>>
>> On 8/25/20 8:30 AM, Lois Foltan wrote:
>>> On 8/25/2020 8:11 AM, Coleen Phillimore wrote:
>>>> This is a cool feature of gtest. Tested with tier1 and with product
>>>> (outside of tier1), since that's a typical failure mode.
>>>>
>>>> open webrev at
>>>> http://cr.openjdk.java.net/~coleenp/2020/8244386.01/webrev
>>>> bug link https://bugs.openjdk.java.net/browse/JDK-8244386
>>>>
>>>> Thanks,
>>>> Coleen
>>>
>>> Looks good. Where are the AssertSafepointCheckConsistency2.java
>>> (false, false) and AssertSafepointCheckConsistency3.java (false,
>>> true) covered in the new test?
>>
>> Thanks Lois. I decided that the test only needs to verify that we
>> check for the erroneous case. The cases that pass are in the code.
>
> Okay, I'm good with your change!
> Lois
>
>>
>> Coleen
>>
>>>
>>> Thanks,
>>> Lois
>>
>
More information about the hotspot-runtime-dev
mailing list