RFR(S) Remove excessive inclusion of arguments.hpp

[Ioi Lam]

Thanks Coleen and Thomas for the review.

- Ioi

On 8/25/20 2:00 PM, Coleen Phillimore wrote:
> +1
> Coleen
>
> On 8/25/20 12:03 AM, Thomas Stüfe wrote:
>> Hi Ioi,
>>
>> thanks for the explanation. Looks all good to me.
>>
>> ..Thomas
>>
>> On Mon, Aug 24, 2020 at 7:16 PM Ioi Lam <ioi.lam at oracle.com> wrote:
>>
>>> Hi Thomas, thanks for the review.
>>>
>>> Some cpp files use vm_exit_during_initialization(), which is defined in
>>> java.hpp, which was included by arguments.hpp.
>>>
>>> Now that I have removed arguments.hpp (indirectly) from these cpp 
>>> files, I
>>> have to add java.hpp to fix the missing dependency.
>>>
>>> Thanks
>>> - Ioi
>>>
>>> On 8/23/20 1:31 AM, Thomas Stüfe wrote:
>>>
>>> Hi Ioi,
>>>
>>> looks okay, but why the added java.hpp includes? At first glance 
>>> does not
>>> seem related to your bug description.
>>>
>>> Thanks Thomas
>>>
>>> On Fri, Aug 21, 2020 at 6:47 PM Ioi Lam <ioi.lam at oracle.com> wrote:
>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8252151
>>>>
>>>> http://cr.openjdk.java.net/~iklam/jdk16/8252151-dont-include-arguments-hpp.v01/ 
>>>>
>>>>
>>>> The large header file arguments.hpp is included by popular header 
>>>> files
>>>> such as constMethod.hpp and methodCounters.hpp (which are included by
>>>> method.hpp, which is included by almost every cpp file).
>>>>
>>>> The dependencies on arguments.hpp by constMethod.hpp are very 
>>>> small, and
>>>> can be moved to constMethod.cpp.
>>>>
>>>> methodCounters.hpp does not depend on arguments.hpp
>>>>
>>>> ===
>>>> by removing these dependencies, we can reduce the total number of
>>>> include files in the hotspot build from 530,921 to 523,010, or a
>>>> reduction of about 1.5%.
>>>>
>>>>
>>>>
>