RFR(s): 8252414: Redundant suspend check when determining if a java thread is safe
David Holmes
david.holmes at oracle.com
Thu Aug 27 08:07:40 UTC 2020
Hi Robbin,
On 27/08/2020 5:21 pm, Robbin Ehn wrote:
> Hi all, please review.
>
> In 8221207 - "Redo JDK-8218446 - SuspendAtExit hangs" we fixed so a
> thread is always blocked when suspended.
>
> And added this nice assert.
> int JavaThread::java_suspend_self() {
> assert(thread_state() == _thread_blocked, "wrong state for
> java_suspend_self()");
>
> When checking if a thread is safepoint/handshake safe there no need to
> look at ext suspend flag anymore, since the thread is blocked.
That seems sound to me. :)
Thanks,
David
-----
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8252414
> Code:
> http://cr.openjdk.java.net/~rehn/8252414/webrev/index.html
>
> Passes t1-5
>
> Thanks, Robbin
More information about the hotspot-runtime-dev
mailing list