RFR (S) 8230052: MLVM findDeadlock test timed out

David Holmes david.holmes at oracle.com
Fri Aug 28 01:14:44 UTC 2020


Hi Coleen,

Fix looks good to me. I second what Ioi suggested - I think simply 
adding a timestamp here:

Env.traceNormal("Iteration " + _iteration + " Starting test...");

would suffice. No need to see updated webrev if you choose that.

Thanks,
David

On 28/08/2020 9:59 am, Ioi Lam wrote:
> Hi Coleen,
> 
>  From the comments of the bug, it looks like we are still not sure 
> whether this happened because we're just running on a slow machine, or 
> whether there's is an real underlying issue.
> 
> Since the test fails very rarely (a few times a year??), if we are 
> modifying it, maybe print out time stamps after every iteration? So if 
> this fails again in six months we will have more info to look at. E.g., 
> if the time stamps are well spaced out, we know we're running on a slow 
> machine. If the time stamps get progressively longer, we probably have a 
> bug in the test or in the VM.
> 
> Thanks
> - Ioi
> 
> On 8/27/20 3:53 PM, Coleen Phillimore wrote:
>> Summary: Add a System.gc() and reduce iteration count for more stability.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/2020/8230052.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8230052
>>
>> Ran test 100x with < 1minute run time.  Should I add a timeout of 10 
>> minutes also?
>>
>> Thanks,
>> Coleen
> 


More information about the hotspot-runtime-dev mailing list